Skip to content

chore: switch Codecov PR comment to default behavior #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2023

Conversation

thymikee
Copy link
Member

Summary

It's super annoying to get dozens of meaningless codecov notifications in my inbox every day, because of the current behavior. Switching to default to "update, if exists. Otherwise post new"

Ref: https://docs.codecov.com/docs/pull-request-comments#behavior

Test plan

Codecov updates instead of recreating the comment

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (90a6169) 96.88% compared to head (74786f9) 96.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   96.88%   96.88%           
=======================================
  Files          65       65           
  Lines        3693     3693           
  Branches      538      538           
=======================================
  Hits         3578     3578           
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thymikee
Copy link
Member Author

No extra emails and the comment is now edited. Perfect!

image

@thymikee thymikee merged commit ce75f66 into main May 31, 2023
@thymikee thymikee deleted the make-codecove-notifications-less-annoying branch May 31, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants