refactor: component tree dead code

[mdjastrzebski]

Summary

Scope:

• Migrate away for composite based checks in component-tree.ts
• Add Switch to detectHostComponentNames and React Native API assumptions tests
• Remove unused component-tree.ts functions: getHostSelf, getCompositeParentOfType, isHostElementForType.

Test plan

N/A

[MattAgn]

Nice cleaning! Are you on a refactoring streak? 😄

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (01af9e7) 96.85% compared to head (d030a18) 96.79%.

❗ Current head d030a18 differs from pull request most recent head fa3b964. Consider uploading reports for the commit fa3b964 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
- Coverage   96.85%   96.79%   -0.06%     
==========================================
  Files          51       51              
  Lines        3461     3404      -57     
  Branches      519      504      -15     
==========================================
- Hits         3352     3295      -57     
  Misses        109      109              

Impacted Files	Coverage Δ
src/config.ts	100.00% <100.00%> (ø)
src/helpers/accessiblity.ts	100.00% <100.00%> (ø)
src/helpers/component-tree.ts	100.00% <100.00%> (ø)
src/helpers/host-component-names.tsx	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mdjastrzebski]

@MattAgn I've managed to find some time and energy to work on User Event type() and I've noticed some code in need for cleanup 🧹🧹🧹

[MattAgn]

Oh great news! On my end, I struggle to find time for fireEvent.press 😅 fortunately @pierrezimmermannbam is here!

[mdjastrzebski]

This PR has been released in v12.1.2 🚀

[BillyBlaze]

@mdjastrzebski thanks for the work.

I'm looking into our dependency update and why the tests are failing from 12.1.1 to 12.1.2. It seems that the newly introduced Switch component is generating an useState hook and that is messing up tests that spies on the useState. Is this by design? and if yes, is this not a breaking change since everyone that spies on the useState suddenly gets more calls and receives a value { value: null } instead of what their useState value should be? It took me some time to figure out that the Switch component was emitting this value and that this was generated in host-component-names.

[mdjastrzebski]

@BillyBlaze thank you for reaching out with your issue. The root cause why RNTL internal code change caused test failures for you is that your test relied on spying on global React primitives, like useState. This way any other component change, in RNTL, React Native or even 3rd party library, could potentially cause test failures.

We do not consider this to be a breaking change, as our public API remained the same and we do not recommend such testing patterns as they result in fragile testing code that is dependent on tested components internal details rather than public API.

Per our guiding principle:

The more your tests resemble the way your software is used, the more confidence they can give you.

The recommended way is to use the public interface: props, event handlers and rendered output of your components to detect expected state behaviors and state changes instead of internal implementation details like internal state, etc.

I hope that clarifies our stance in this regards and allows you to write more resilient tests.