feat: alias isInaccessible as isHiddenFromAccessibility #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
requested review from
AugustinLF,
pierrezimmermannbam and
thymikee
and removed request for
pierrezimmermannbam
Codecov ReportBase: 94.38% // Head: 94.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
==========================================
+ Coverage 94.38% 94.49% +0.11%
==========================================
Files 42 42
Lines 2936 2927 -9
Branches 435 435
==========================================
- Hits 2771 2766 -5
+ Misses 165 161 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pierrezimmermannbam
approved these changes
Nov 4, 2022
mdjastrzebski
force-pushed
the
feature/rename-is-hidden-from-accessibility
branch
from
4a713f9 to
f54a037
Compare
AugustinLF
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename
isInaccessibleasisHiddenFromAccessibility. Then provide RTL-compat aliasisInaccessible, but only as a secondary option.Test plan
Update existing tests to use
isHiddenFromAccessibility.