Ignore fake timers #1169
Merged
Ignore fake timers #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/helpers/__tests__/timers.test.ts
Outdated
| import { jestFakeTimersAreEnabled } from '../timers'; | ||
| describe('timers', () => { | ||
| it('should not mock timers if SKIP_AUTO_FAKE_TIMERS_DETECTION is set', async () => { | ||
| process.env.SKIP_AUTO_FAKE_TIMERS_DETECTION = 'true'; |
There was a problem hiding this comment.
Suggested change
| process.env.SKIP_AUTO_FAKE_TIMERS_DETECTION = 'true'; | |
| process.env.RNTL_SKIP_AUTO_DETECT_FAKE_TIMERS = 'true'; |
Let's add RNTL_ prefix as for RNTL_SKIP_AUTO_CLEANUP.
nit: I've also suggested AUTO_DETECT_FAKE_TIMERS vs AUTO_FAKE_TIMER_DETECTION as slightly more readable.
There was a problem hiding this comment.
Looks good!
@Niryo pls document this settings. This should probably be very brief, you can put it under configuration section in API.md file
|
@mdjastrzebski added docs |
mdjastrzebski
approved these changes
Oct 18, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow explicitly disabling automatic jest fake timers detection in order to solve #886
Test plan