-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix devcontainer #3251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix devcontainer #3251
Conversation
Thanks! Will be a bit slow to follow up as I'm in the mountains for a few more days - will be home in a few in case I seem awol. |
I'm a bit confused as to why the tests are failing? Nothing you changed should have impacted the tests at all afaict? any ideas?... |
Into the github action the database host is "localhost" https://github.com/brianc/node-postgres/blob/master/.github/workflows/ci.yml#L52, Instead into devcontainer is "db" https://github.com/nigrosimone/node-postgres/blob/patch-1/.devcontainer/docker-compose.yml#L44. The test run successfully into devcontainer, but fail into github action. Simply need to use the same host name.
This is the commit of hostname change fd1af11 |
k - should probably revert the changes to the native test or make it consistent everywhere - can't merge this w/o tests passing! |
@brianc I have reverted the failing test and made some other changes for latest vscode |
@nigrosimone thanks for your help! Will run tests & then merge this. ❤️ |
Also fix #3049