pg-pool: don't allow connection reuse after streaming #2832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
commented
Oct 5, 2022
packages/pg-pool/index.js
Outdated
| @@ -331,7 +331,7 @@ class Pool extends EventEmitter { | |||
| client._poolUseCount = (client._poolUseCount || 0) + 1 | |||
|
|
|||
| // TODO(bmc): expose a proper, public interface _queryable and _ending | |||
| if (err || this.ending || !client._queryable || client._ending || client._poolUseCount >= this.options.maxUses) { | |||
| if (err || this.ending || !client._queryable || client._ending || client._poolUseCount >= this.options.maxUses || client?.activeQuery?.cursor) { | |||
There was a problem hiding this comment.
This probably isn't the correct way to check if the activeQuery is a QueryStream, but using isntanceof doesn't seem appropriate: AFAICT there's currently no dependency from pg-pool -> pg-query-stream, and there probably shouldn't be.
charmander
requested changes
Oct 5, 2022
|
@charmander thanks for the feedback, I don't disagree. If it was good, it wouldn't be a hack 😄 Does the test case look valid to you? Perhaps Do you have any suggestions on a more correct approach to fixing the issue? |
|
Closing in favour of #2836. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a fix for #1674.
I would expect that connections could be re-used safely after streaming though, so there should be a more correct way of approaching this...