Skip to content

compare prepared statement text with previous to prevent incorrect queries #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2019
Merged

compare prepared statement text with previous to prevent incorrect queries #1814

merged 2 commits into from
Mar 6, 2019

Conversation

Rich-Harris
Copy link
Contributor

Closes #1813

@sehrope
Copy link
Contributor

sehrope commented Jan 15, 2019

+1. Overall looks good but I'd changed the error message a bit. It's got a Unicode — (—) rather than regular dash ("-"). Also the reference to plural "queries" should be singular and it could be any type of statement.

How about:

Prepared statements must be unique - '${this.name}' was used for a different statement

@Rich-Harris
Copy link
Contributor Author

Thanks for taking a look — I've made that change

@brianc
Copy link
Owner

brianc commented Mar 6, 2019

Nice I'll release a new semver patch w/ this change ASAP! Sorry for the delay.

@brianc brianc merged commit e6a878c into brianc:master Mar 6, 2019
@Rich-Harris Rich-Harris deleted the unique-prepared-statements branch March 6, 2019 15:37
@Rich-Harris
Copy link
Contributor Author

excellent, thank you!

@brianc
Copy link
Owner

brianc commented Mar 7, 2019

published [email protected] - thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charmander charmander charmander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rich-Harris @sehrope @brianc @charmander