Skip to content

Remove deprecated pool options from defaults #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2017
Merged

Remove deprecated pool options from defaults #1438

merged 4 commits into from
Sep 3, 2017

Conversation

abenhamdine
Copy link
Contributor

@abenhamdine abenhamdine commented Aug 30, 2017

Since the upgrade of pg-pool to version 2.X, some properties seemingly have been removed from the pool options :

  • reapIntervalMillis, returnToHead and poolLog no more exist : I didn't find any occurrence of them in the code
  • poolIdleTimeout has been replaced by idleTimeoutMillis

I also have changed poolSize to max : while poolSize is still allowed in node-pg-pool, only the option max is documented in the readme, see https://github.com/brianc/node-pg-pool/blob/master/README.md

In configuration test, I added more default properties assertions.

I also changed the pool url to link to node-pg-pool in the comments.

@brianc
Copy link
Owner

brianc commented Sep 3, 2017

Awesome, thanks! I'll roll here in a bit. Gonna push a new minor version to support statement timeouts too.

@brianc brianc merged commit 4936033 into brianc:master Sep 3, 2017
@abenhamdine
Copy link
Contributor Author

Thx for merging !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants