Remove deprecated pool options from defaults #1438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the upgrade of pg-pool to version 2.X, some properties seemingly have been removed from the pool options :
reapIntervalMillis
,returnToHead
andpoolLog
no more exist : I didn't find any occurrence of them in the codepoolIdleTimeout
has been replaced byidleTimeoutMillis
I also have changed
poolSize
tomax
: whilepoolSize
is still allowed in node-pg-pool, only the optionmax
is documented in the readme, see https://github.com/brianc/node-pg-pool/blob/master/README.mdIn configuration test, I added more default properties assertions.
I also changed the pool url to link to node-pg-pool in the comments.