Skip to content

NEWS item bogus about pg.connect() taking 3 args #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
strk opened this issue May 24, 2013 · 3 comments
Closed

NEWS item bogus about pg.connect() taking 3 args #358

strk opened this issue May 24, 2013 · 3 comments

Comments

@strk
Copy link
Contributor

strk commented May 24, 2013

The wiki page does NOT present a pg.Connect() call taking 3 arguments but the NEWS file says that since v1.0 it is required to pass 3 arguments.
@strk
Copy link
Contributor Author

strk commented May 24, 2013

Forget it, I got it, it's the number of params to the callback, not to the function

@strk strk closed this as completed May 24, 2013
@strk
Copy link
Contributor Author

strk commented May 24, 2013

Actually, on a second read, it's the NEWS file being bogus. It says "pg.connect now requires 3 arguments" which isn't true. It's the callback passed to it that needs take 3 arguments.

@strk strk reopened this May 24, 2013
strk pushed a commit to CartoDB/node-postgres that referenced this issue May 28, 2013
Fix NEWS item about pg.connect callback. CLoses brianc#358.
0a40afc
@strk strk mentioned this issue May 28, 2013
Merged
@strk
Copy link
Contributor Author

strk commented May 28, 2013

Please merge #362 to fix NEWS file

@strk strk closed this as completed May 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@strk