-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
pg-connection-string v2.8.0 broke default export #3424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
looking at [email protected]@2.8.0 i wonder if 940479b caused an issue |
Prior to v2.8.0, the parse function was the default when using import. When esm compatibility was introduced in v2.8.0, there was not default specified. This broke existing code that relied on that default. Fixes #3424
+1, had the same issue this morning |
so sorry! Publishing a fix right now |
@brianc thanks for such a quick fix 🙌🙌 that was awesome! I hadn't expected to hear back, much less so soon |
❤ thanks for letting me know! I always try to do a release in the morning so I can be extra vigilant on monitoring my github issues for the first day just incase something like this happens! I've been on the receiving end of unintended (and also semver major) breaking changes enough to know the pain, and I want to reduce that pain for as many folks as possible. |
Originally posted by @ThisIsMissEm in #3421
The text was updated successfully, but these errors were encountered: