Different behavior calling .end() on a non connected Client between 7.17 and 7.18

[InExtremaRes]

Calling client.end() on a Client not connected in [email protected] fails with an error message

Socket is closed

However in [email protected] the same call just hangs indefinitely. I'm using the promise-based call (without the callback) and awaiting the promise to fulfil.

Is this an expected change?

If the context matters, I have a wrapper around a Client and I'm "unit testing" that a call to its closing function throws if the wrapped client is not connected. Before I was just calling .end() on the inner client but now the test fails since the promise never fulfilled.

If the change is expected, is there a way of knowing if a given Client is connected?

[brianc]

nope! not an expected change. hanging indefinitely is never my intended behavior! i didn't really think about what would happen if you call .close on an unconnected client. i think it should just silently do nothing...what do you think? i can write a test for this behavior and ensure it stays consistent going forward

…

On Thu, Feb 20, 2020 at 10:07 AM Daniel Contreras ***@***.***> wrote: Calling client.end() on a Client not connected in ***@***.*** fails with an error message Socket is closed However in ***@***.*** the same call just hangs indefinitely. I'm using the promise-based call (without the callback) and awaiting the promise to fulfil. Is this an expected change? If the context matters, I have a wrapper around a Client and I'm "unit testing" that a call to its closing function throws if the wrapped client is not connected. Before I was just calling .end() on the inner client but now the test fails since the promise never fulfilled. If the change is expected, is there a way of knowing if a given Client is connected? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2108?email_source=notifications&email_token=AAAMHIODDE4GV5GD5REZMF3RD2TFTA5CNFSM4KYR6YF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPBGP6A>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAMHIL7JPMVGMRK3D3X2GDRD2TFTANCNFSM4KYR6YFQ> .

[InExtremaRes]

Yep. As long a it is consistent and documented a noop looks good to me. But still I think there should be a public way of knowing if a client is connected. I think there is a _connected property but seems to be private.

In our case we do want to throw in that case since it can only happen due a developer mistake and not as a normal flow path; our wrapper can throw if the inner client is not connected and pg.Client can then just do nothing if .end() is called. Is that possible?