Skip to content

Support [email protected] #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@ node_modules
*.log
dist
coverage
package-lock.json

16 changes: 2 additions & 14 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,9 @@
sudo: false
language: node_js
node_js:
- 4
- 6
- 8
env:
- USE_WEBPACK2=false
- USE_WEBPACK2=true
matrix:
exclude:
# TODO: Fix barf on peer dependencies with npm@2.
- env: USE_WEBPACK2=true
node_js: 4

before_install:
- 'if [ "${USE_WEBPACK2}" == "true" ]; then npm install --save-dev [email protected] [email protected]; fi'

- 10
- 12
after_script:
- npm install coveralls
- cat ./coverage/coverage.json | ./node_modules/.bin/adana --format lcov | ./node_modules/coveralls/bin/coveralls.js
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ npm install --save css-split-webpack-plugin
Simply add an instance of `CSSSplitWebpackPlugin` to your list of plugins in your webpack configuration file _after_ `ExtractTextPlugin`. That's it!

```javascript
var ExtractTextPlugin = require('extract-text-webpack-plugin');
var MiniCssExtractPlugin = require('mini-css-extract-plugin');
var CSSSplitWebpackPlugin = require('../').default;

module.exports = {
Expand All @@ -35,11 +35,14 @@ module.exports = {
module: {
loaders: [{
test: /\.css$/,
loader: ExtractTextPlugin.extract('style-loader', 'css-loader'),
use: [
MiniCssExtractPlugin.loader,
'css-loader',
],
}],
},
plugins: [
new ExtractTextPlugin('styles.css'),
new MiniCssExtractPlugin({filename: 'style.css'}),
new CSSSplitWebpackPlugin({size: 4000}),
],
};
Expand Down
20 changes: 10 additions & 10 deletions example/basic/webpack.config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var ExtractTextPlugin = require('extract-text-webpack-plugin');
var CSSSplitWebpackPlugin = require('../../').default;
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const CSSSplitWebpackPlugin = require('../../').default;

module.exports = {
entry: './index.js',
Expand All @@ -10,19 +10,19 @@ module.exports = {
filename: 'bundle.js',
},
module: {
loaders: [{
rules: [{
test: /\.css$/,
loader: ExtractTextPlugin.extract.length !== 1 ?
ExtractTextPlugin.extract('style-loader', 'css-loader') :
ExtractTextPlugin.extract({
fallbackLoader: 'style-loader',
loader: 'css-loader',
}),
use: [
MiniCssExtractPlugin.loader,
'css-loader',
],
}],
},
devtool: 'source-map',
plugins: [
new ExtractTextPlugin("styles.css"),
new MiniCssExtractPlugin({
filename: 'styles.css',
}),
new CSSSplitWebpackPlugin({size: 3, imports: true}),
],
};
18 changes: 11 additions & 7 deletions example/less/webpack.config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var ExtractTextPlugin = require('extract-text-webpack-plugin');
var CSSSplitWebpackPlugin = require('../../').default;
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const CSSSplitWebpackPlugin = require('../../').default;

module.exports = {
entry: './index.js',
Expand All @@ -10,16 +10,20 @@ module.exports = {
filename: 'bundle.js',
},
module: {
loaders: [{
rules: [{
test: /\.less$/,
loader: ExtractTextPlugin.extract(
'css?-url&-autoprefixer&sourceMap!less?sourceMap'
),
use: [
MiniCssExtractPlugin.loader,
'css-loader',
'less-loader',
],
}],
},
devtool: 'source-map',
plugins: [
new ExtractTextPlugin("styles.css"),
new MiniCssExtractPlugin({
filename: 'styles.css',
}),
new CSSSplitWebpackPlugin({size: 3}),
],
};
Loading