Skip to content

Source maps not working with less #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kfeinUI opened this issue Jun 1, 2016 · 3 comments
Closed

Source maps not working with less #4

kfeinUI opened this issue Jun 1, 2016 · 3 comments

Comments

@kfeinUI
Copy link

kfeinUI commented Jun 1, 2016

I load in less like so
{ test: /\.(less|css)$/, loader: ExtractTextPlugin.extract('css?-url&-autoprefixer&sourceMap!less?sourceMap') }
with plugins
new ExtractTextPlugin('[name].css'), new CSSSplitWebpackPlugin({ //IE9 will ignore any more than ~4000 selectors. This does the work for us of splitting into smaller files. imports: true, preserve: true })

Tried with and without preserve. Even with the preserved sheet, the source map won't load (testing in Chrome). Works fine when I comment out this plugin.

@izaakschroeder
Copy link
Contributor

Thanks for the report! Will investigate this. 😄

@kfeinUI
Copy link
Author

kfeinUI commented Jun 2, 2016

Cool. Let me know if you need anything further from my end. Would be nice to get source maps working for either case, but I'd settle for keeping the preserved flavor for modern browsers (can use conditional comments).

izaakschroeder added a commit that referenced this issue Jun 6, 2016
The previous source map should be applied in `process`, not in `toResult` even though the documentation says `toResult` supports these properties. See: https://github.com/postcss/postcss/blob/master/docs/api.md#roottoresultopts for information on this API. Additional tests have been added to verify this behavior, including the addition of a more complex example using the `less` CSS preprocessor.

Fixes #4.
izaakschroeder added a commit that referenced this issue Jun 6, 2016
The previous source map should be applied in `process`, not in `toResult` even though the documentation says `toResult` supports these properties. See: https://github.com/postcss/postcss/blob/master/docs/api.md#roottoresultopts for information on this API. Additional tests have been added to verify this behavior, including the addition of a more complex example using the `less` CSS preprocessor.

Fixes #4.
@izaakschroeder
Copy link
Contributor

@kfeinUI Resolved here: #6. 😄 Should be merged and published soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants