-
-
Notifications
You must be signed in to change notification settings - Fork 13
Update dependencies #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
As of v6.0.4, everything beside |
When to support postcss version 8.x . |
@dxhuii I have not noticed it requires an update until your message. After a brief look, it seems to require some updates in the plugin code. I'll try to do it this week, depending on how tough the changes are, and how much time I have. |
ok |
I saw today that postcss has been upgraded to 8.1.1, I wonder if other dependencies have been upgraded. Began to report errors again, it feels like this upgrade is really endless, has been the problem, not across the big version, surprisingly also have problems. The errors are as follows. ERROR in ./src/app/components/Detail/index.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: /Users/dingxiaohui/Documents/web/react-5ddm/src/app/components/Detail/index.js: Could not resolve the styleName 'detail-mini'.
at handleError (/Users/dingxiaohui/Documents/web/react-5ddm/node_modules/@dr.pogodin/babel-plugin-react-css-modules/dist/getClassName.js:18:11)
at /Users/dingxiaohui/Documents/web/react-5ddm/node_modules/@dr.pogodin/babel-plugin-react-css-modules/dist/getClassName.js:103:14
at Array.map (<anonymous>)
at _default (/Users/dingxiaohui/Documents/web/react-5ddm/node_modules/@dr.pogodin/babel-plugin-react-css-modules/dist/getClassName.js:83:6)
at _default (/Users/dingxiaohui/Documents/web/react-5ddm/node_modules/@dr.pogodin/babel-plugin-react-css-modules/dist/resolveStringLiteral.js:20:55)
at PluginPass.JSXElement (/Users/dingxiaohui/Documents/web/react-5ddm/node_modules/@dr.pogodin/babel-plugin-react-css-modules/dist/index.js:191:47)
at newFn (/Users/dingxiaohui/Documents/web/react-5ddm/node_modules/@babel/traverse/lib/visitors.js:175:21)
at NodePath._call (/Users/dingxiaohui/Documents/web/react-5ddm/node_modules/@babel/traverse/lib/path/context.js:55:20)
at NodePath.call (/Users/dingxiaohui/Documents/web/react-5ddm/node_modules/@babel/traverse/lib/path/context.js:42:17)
at NodePath.visit (/Users/dingxiaohui/Documents/web/react-5ddm/node_modules/@babel/traverse/lib/path/context.js:92:31)
@ ./src/app/components/Vod/index.js 12:37-67
@ ./src/app/components/SideBar/index.js
@ ./src/app/pages/subject/news/index.js
@ ./src/app/router/list.js
@ ./src/app/router/index.js
@ ./src/client/index.js
@ multi webpack-hot-middleware/client?path=http://localhost:4001/__webpack_hmr @babel/polyfill ./src/client/index 依赖版本 "postcss": "^8.0.9", 3 days ago update 8.1.1
"postcss-flexbugs-fixes": "^4.2.1", No update
"postcss-loader": "^4.0.2", No update in the last 15 days
"postcss-nested": "^5.0.0", 3 days ago update 5.0.1
"postcss-scss": "^3.0.1", 3 days ago update 3.0.2 |
Yeah @dxhuii , they released PostCSS 8.0.x with a bug in the new AST walking logic, which behaved simlar to 7.x. They fixed it in 8.1.x, and it became a breaking change which was supposed to be a part of 8.0.x release. I just patched this plugin, v6.0.6 should work fine with PostCSS 8.1.x (I am still to double-check it in a real project, and if I find some problems, I'll patch it further shortly). |
Ok, I'm testing so far with no problems. |
A naive attempt to update current NPM dependencies to latest versions fails miserably: it breaks flow tests (because of breaking change in https://github.com/facebook/flow/blob/master/Changelog.md#01320 (disallow using any-typed values type annotations); it also breaks the build because of some issue with source maps generation.
Thus, it needs some time to do the update properly.
The text was updated successfully, but these errors were encountered: