Skip to content

build: 📦 github artifact actions to v4 (major) #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

build: 📦 github artifact actions to v4 (major) #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e06d452
build: 📦 github artifact actions to v4
renovate[bot] Oct 22, 2024
94f98ed
ci: store only one report
dianjuar Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/download-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ runs:
using: composite
steps:
- name: Download dist folder
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: library-dist-${{ github.sha }}
path: dist
2 changes: 1 addition & 1 deletion .github/actions/download-coverage-report/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ runs:
using: composite
steps:
- name: Download coverage report
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ngx-deploy-npm-coverage-report-${{ github.sha }}
path: coverage/packages/ngx-deploy-npm
2 changes: 1 addition & 1 deletion .github/actions/download-lint-report/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ runs:
using: composite
steps:
- name: Download lint report
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: lint-report-${{ github.sha }}
path: reports
16 changes: 12 additions & 4 deletions .github/workflows/basic-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
run: npx nx lint-report ngx-deploy-npm

- name: Archive lint report results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: lint-report-${{ github.sha }}
path: reports
Expand All @@ -30,7 +30,7 @@ jobs:
- run: npx nx build ngx-deploy-npm

- name: Archive build result
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: library-dist-${{ github.sha }}
path: dist
Expand All @@ -49,9 +49,17 @@ jobs:

- run: npx nx test ngx-deploy-npm --configuration="ci"

- if: ${{ matrix.os == 'ubuntu-latest' }}
- name: Set Node.js version based on .nvmrc
shell: bash
run: |
version=$(cat .nvmrc)
echo "Setting default value for node-version parameter: $version"
echo "NODE_VERSION=$version" >> $GITHUB_ENV
echo "$NODE_VERSION"

- if: ${{ matrix.os == 'ubuntu-latest' && matrix.node-version == env.NODE_VERSION }}
name: Archive coverage report
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ngx-deploy-npm-coverage-report-${{ github.sha }}
path: coverage/packages/ngx-deploy-npm/lcov.info
2 changes: 0 additions & 2 deletions .github/workflows/publishment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@ on:

jobs:
test:
if: ${{ !contains(github.event.head_commit.message, 'chore(release)') }}
uses: ./.github/workflows/basic-test.yml

e2e-test:
if: ${{ !contains(github.event.head_commit.message, 'chore(release)') }}
uses: ./.github/workflows/e2e-test.yml

backwards-compatibility-test:
Expand Down