Skip to content

fix!: change configuration parameter for buildTarget #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

dianjuar
Copy link
Member

@dianjuar dianjuar commented Mar 2, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://www.conventionalcommits.org/en/v1.0.0/
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Both workspaces were tested Angular an Nx

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Chore
  • Refactoring (no functional changes, no api changes)
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

The parameter configuration is migrated to buildTarget.
For migration just change --configuration for --build-target on the command line and on the configuration file configuration for buildTarget

Other information

@dianjuar dianjuar marked this pull request as draft March 2, 2021 04:39
@dianjuar dianjuar force-pushed the migrate-configuration-to-build-target branch from 1ce09b1 to 6665bfe Compare March 3, 2021 03:02
@dianjuar dianjuar marked this pull request as ready for review March 3, 2021 03:19
@dianjuar
Copy link
Member Author

dianjuar commented Mar 3, 2021

Closes #60

@dianjuar
Copy link
Member Author

dianjuar commented Mar 3, 2021

FYI @JohannesHoppe

@JohannesHoppe
Copy link

😎👍

BREAKING CHANGE, the parameter configuration is migrated to buildTarget.
Just change --configuration for --build-target on the command line and on the configuration file configuration for buildTarget
@dianjuar dianjuar force-pushed the migrate-configuration-to-build-target branch from 6665bfe to f13bb6b Compare March 4, 2021 02:32
@dianjuar dianjuar merged commit f987eec into master Mar 4, 2021
@dianjuar dianjuar deleted the migrate-configuration-to-build-target branch March 4, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants