Skip to content

fix: add setuptools to pyproject.toml to fix issue with setuptools 50 BNCH-17644 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

fix: add setuptools to pyproject.toml to fix issue with setuptools 50 BNCH-17644 #9

merged 1 commit into from
Oct 16, 2020

Conversation

dtkav
Copy link

@dtkav dtkav commented Oct 16, 2020

Setuptools issue: pypa/setuptools#2353

@dtkav dtkav requested a review from bowenwr October 16, 2020 00:04
@dtkav
Copy link
Author

dtkav commented Oct 16, 2020

@bowenwr can you make sure i'm not causing a regression with the httpx version change?

bowenwr
bowenwr approved these changes Oct 16, 2020
View reviewed changes
Copy link

@bowenwr bowenwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated a client from this version locally, added it to the SDK, and ran the SDK unit tests with no issues.

@dtkav dtkav merged commit cbff87f into main Oct 16, 2020
@eli-bl eli-bl deleted the BNCH-17644-setuptool-50-fixes branch November 20, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenwr bowenwr bowenwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtkav @bowenwr