Skip to content

PayloadS3Pointer inefficiently uses Jackson's ObjectMapper #51

Open
@Logic-32

Description

@Logic-32

Ref:

Reuse heavy-weight objects: ObjectMapper (data-binding) and JsonFactory (streaming API)
To a lesser degree, you may also want to reuse ObjectReader and ObjectWriter instances -- this is just some icing on the cake, but they are fully thread-safe and reusable

Short version:

  1. PayloadS3Pointer instantiates a new JsonDataConverter for every toJson() invocation.
  2. JsonDataConverter instantiates a new ObjectMapper for every invocation.

When used via a S3BackedPayloadStore in the SQS Extended Client and sending a ton of SQS messages, this can add up to quite the performance hit.

If you flipped this on its head and

  1. Had the PayloadStore contain an ObjectMapper
  2. Got rid of the toJson() method
  3. Serialized the PayloadS3Pointer directly in the PayloadStore

Then you could see some performance benefit by having one ObjectMapper per-PayloadStore. But, making a static, hidden, shared ObjectMapper throughout the entire library would see the biggest benefits. Again, probably contained in a Singleton wrapper class that is used and/or injected everywhere.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions