Skip to content

Fix: Missing userNotFound field in "create/verify auth challenge" Cognito user pool events #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2023
Merged

Fix: Missing userNotFound field in "create/verify auth challenge" Cognito user pool events #719

merged 2 commits into from
Nov 4, 2023

Conversation

kikuomax
Copy link
Contributor

@kikuomax kikuomax commented Nov 4, 2023

Issue

Description of changes:

  • Add user_not_found field to:
    • CognitoEventUserPoolsCreateAuthChallengeRequest
    • CognitoEventUserPoolsVerifyAuthChallengeRequest
  • Add test cases where user_not_found becomes true for:
    • CognitoEventUserPoolsDefineAuthChallengeRequest
    • CognitoEventUserPoolsCreateAuthChallengeRequest
    • CognitoEventUserPoolsVerifyAuthChallengeRequest

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@kikuomax
Add user_not_found to Create/Verify auth challenge events
8e1b8a1 
- Adds `user_not_found` field to:
    - `CognitoEventUserPoolsCreateAuthChallengeRequest`
    - `CognitoEventUserPoolsVerifyAuthChallengeRequest`
- Adds test cases where `user_not_found` becomes `true` for:
    - `CognitoEventUserPoolsDefineAuthChallengeRequest`
    - `CognitoEventUserPoolsCreateAuthChallengeRequest`
    - `CognitoEventUserPoolsVerifyAuthChallengeRequest`

issue awslabs#718
calavera
calavera suggested changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run cargo fmt to fix the formatting issues? 🙏

calavera
calavera approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@calavera calavera merged commit c565173 into awslabs:main Nov 4, 2023
@kikuomax kikuomax deleted the missing-user-not-found branch November 5, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calavera calavera calavera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing userNotFound field in "create/verify auth challenge" Cognito user pool events
2 participants
@kikuomax @calavera