Fixed media type suffix detection #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content-Type value contains media type and optional parameters (such as charset, boundary, filename, and Content-Disposition). So we need to extract the media type part and compare its suffix.
calavera
reviewed
Oct 29, 2023
lambda-http/src/response.rs
Outdated
| let parts = content_type.trim().split(';'); | ||
|
|
||
| let mut media_type = String::new(); | ||
| for part in parts { |
There was a problem hiding this comment.
I'm pretty sure that the mime type is always the first value if you split the header value with ;. You might not need to iterate over all the parts, you can take the first element.
As far as I know the value's syntax is MIMETYPE; PARAMETERS
There was a problem hiding this comment.
If that's not the only valid syntax, we should test other possible values.
There was a problem hiding this comment.
Right. I simplified the code to take the first element.
calavera
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related to awslabs/aws-lambda-web-adapter#265
Description of changes:
Content-Type value contains media type and optional parameters (such as charset, boundary, filename, and Content-Disposition). So we need to extract the media type part and compare its suffix. Otherwise, the response body will be treated as binary.
By submitting this pull request