Skip to content

fix(parameters): fix import path to use relative paths #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

karthikeyanjp
Copy link
Contributor

@karthikeyanjp karthikeyanjp commented Mar 28, 2023

Description of your changes

package: parameters

AppConfigProvider.ts uses incorrect import path for GetOptionsInterface. This fix will use the correct relative path for the import.

This fix is for the issue #1385

Related issues, RFCs

Issue number: #1385


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Mar 29, 2023
@dreamorosi dreamorosi added parameters This item relates to the Parameters Utility and removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Mar 29, 2023
@dreamorosi dreamorosi self-requested a review March 29, 2023 08:23
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick turnaround @karthikeyanjp, appreciate your PR and congrats for your first contribution 🎉

@dreamorosi dreamorosi merged commit 40a1a24 into aws-powertools:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parameters This item relates to the Parameters Utility size/XS PR between 0-9 LOC
Projects
None yet
2 participants