Bug: Build of @aws-lambda-powertools/parameters fails as types/AppConfigProvider.ts uses import with absolute file name

[karthikeyanjp]

Expected Behaviour

Refer code.

import type {
  AppConfigDataClient,
  AppConfigDataClientConfig,
  StartConfigurationSessionCommandInput,
} from '@aws-sdk/client-appconfigdata';
import type { GetOptionsInterface } from 'types/BaseProvider';

Import for GetOptionsInterface should be from './BaseProvider'.

Since the import is using an incorrect path, build fails. See error below:

│ ../../node_modules/.pnpm/@[email protected]/node_modules/@aws-lambda-powertools/parameters/types/AppConfigProvider.d.ts:2:42 - e
│ 2 import type { GetOptionsInterface } from 'types/BaseProvider';
│                                            ~~~~~~~~~~~~~~~~~~~~
│ Found 1 error in ../../node_modules/.pnpm/@[email protected]/node_modules/@aws-lambda-powertools/parameters/types/AppConfigProvi
│  ELIFECYCLE  Command failed with exit code 2.

Current Behaviour

GetOptionsInterface is imported from incorrect path.

import type {
  AppConfigDataClient,
  AppConfigDataClientConfig,
  StartConfigurationSessionCommandInput,
} from '@aws-sdk/client-appconfigdata';
import type { GetOptionsInterface } from 'types/BaseProvider';

Code snippet

GetOptionsInterface is imported from incorrect path.

import type {
  AppConfigDataClient,
  AppConfigDataClientConfig,
  StartConfigurationSessionCommandInput,
} from '@aws-sdk/client-appconfigdata';
import type { GetOptionsInterface } from 'types/BaseProvider';

Steps to Reproduce

pnpm run build

Possible Solution

Import GetOptionsInterface from correct path.

import type {
  AppConfigDataClient,
  AppConfigDataClientConfig,
  StartConfigurationSessionCommandInput,
} from '@aws-sdk/client-appconfigdata';
import type { GetOptionsInterface } from './BaseProvider';

AWS Lambda Powertools for TypeScript version

latest

AWS Lambda function runtime

18.x

Packaging format used

npm

Execution logs

No response

[dreamorosi]

Hi @karthikeyanjp thank you for spotting this and for taking the time to report it.

The report is valid and the import should indeed be: import type { GetOptionsInterface } from './BaseProvider'; (like you suggested).

Would you be interested in contributing a fix via PR? If not, we'll definitely address this before the next beta release.

[karthikeyanjp]

@dreamorosi sure, I will submit a PR for this.

[dreamorosi]

Awesome, thank you!

Note that I have updated my previous comment, the fix you suggested in your OP is correct.

[karthikeyanjp]

@dreamorosi Submitted PR#1388. Kindly review at your convenience.

[github-actions]

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.