fix(docs): use concrete secrets from settings #2322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
github-actions
pull-request-size
bot
added
the
size/S
heitorlessa
suggested changes
May 24, 2023
heitorlessa
reviewed
May 24, 2023
Comment on lines
8
to
14
| secrets: | ||
| AWS_DOCS_ROLE_ARN: | ||
| description: Docs IAM Role | ||
| required: false | ||
| AWS_DOCS_BUCKET: | ||
| description: Docs S3 Bucket | ||
| required: false |
There was a problem hiding this comment.
use secrets: inherit instead from the caller
There was a problem hiding this comment.
In addition to this, use environment: Docs in the caller, and move the secrets into the Docs environment please. Don't leave any "Repository secrets".
rubenfonseca
suggested changes
May 24, 2023
Comment on lines
8
to
14
| secrets: | ||
| AWS_DOCS_ROLE_ARN: | ||
| description: Docs IAM Role | ||
| required: false | ||
| AWS_DOCS_BUCKET: | ||
| description: Docs S3 Bucket | ||
| required: false |
There was a problem hiding this comment.
In addition to this, use environment: Docs in the caller, and move the secrets into the Docs environment please. Don't leave any "Repository secrets".
pull-request-size
bot
added
size/XS
Signed-off-by: Simon Thulbourn <[email protected]>
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
May 26, 2023
* develop: chore(deps-dev): bump aws-cdk from 2.80.0 to 2.81.0 (aws-powertools#2332) chore(deps-dev): bump coverage from 7.2.5 to 7.2.6 (aws-powertools#2326) chore(deps-dev): bump pytest-cov from 4.0.0 to 4.1.0 (aws-powertools#2327) chore(deps): bump actions/setup-python from 4.6.0 to 4.6.1 (aws-powertools#2325) fix(docs): use concrete secrets from settings (aws-powertools#2322) fix(logger): add setLevel function to set level programmatically (aws-powertools#2320) feat(parser): add support for parsing SQS events wrapped in Kinesis Firehose (aws-powertools#2294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2277
Summary
Changes
Forces GHA to use the secrets stored in the repository.
User experience
No change
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.