Skip to content

fix(docs): use concrete secrets from settings #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2023
Merged

fix(docs): use concrete secrets from settings #2322

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13c7f39
fix(docs): use concrete secrets from settings
sthulb May 24, 2023
7b43749
pass environment maybe
sthulb May 24, 2023
5ea9672
remove input
sthulb May 24, 2023
f52b304
add actual env name
sthulb May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/on_push_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,6 @@ jobs:
with:
version: develop
alias: stage
secrets:
AWS_DOCS_ROLE_ARN: ${{ secrets.AWS_DOCS_ROLE_ARN }}
AWS_DOCS_BUCKET: ${{ secrets.AWS_DOCS_BUCKET }}
3 changes: 3 additions & 0 deletions .github/workflows/publish_v2_layer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,3 +229,6 @@ jobs:
version: ${{ inputs.latest_published_version }}
alias: ${{ needs.prepare_docs_alias.outputs.DOCS_ALIAS }}
git_ref: ${{ needs.update_v2_layer_arn_docs.outputs.temp_branch }}
secrets:
AWS_DOCS_ROLE_ARN: ${{ secrets.AWS_DOCS_ROLE_ARN }}
AWS_DOCS_BUCKET: ${{ secrets.AWS_DOCS_BUCKET }}
3 changes: 3 additions & 0 deletions .github/workflows/rebuild_latest_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,6 @@ jobs:
with:
version: ${{ inputs.latest_published_version }}
alias: latest
secrets:
AWS_DOCS_ROLE_ARN: ${{ secrets.AWS_DOCS_ROLE_ARN }}
AWS_DOCS_BUCKET: ${{ secrets.AWS_DOCS_BUCKET }}
7 changes: 7 additions & 0 deletions .github/workflows/reusable_publish_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ env:

on:
workflow_call:
secrets:
AWS_DOCS_ROLE_ARN:
description: Docs IAM Role
required: false
AWS_DOCS_BUCKET:
description: Docs S3 Bucket
required: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use secrets: inherit instead from the caller

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to this, use environment: Docs in the caller, and move the secrets into the Docs environment please. Don't leave any "Repository secrets".

inputs:
version:
description: "Version to build and publish docs (1.28.0, develop)"
Expand Down