Add User-Agent information #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dislogical
reviewed
Dec 10, 2018
src/runtime.cpp
Outdated
| @@ -105,6 +106,12 @@ static size_t write_header(char* ptr, size_t size, size_t nmemb, void* userdata) | |||
| return size * nmemb; | |||
| } | |||
|
|
|||
| static std::string get_user_agent_header() | |||
There was a problem hiding this comment.
You could probably return this by const reference, since it's a static?
Send a user-agent http header when talking to Lambda's http server. This is important for collecting usage metrics.
marcomagdy
force-pushed
the
useragent
branch
from
f673a2b to
cc0090d
Compare
dislogical
approved these changes
Dec 11, 2018
bmoffatt
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send a user-agent http header when talking to Lambda's http server.
This is important for collecting usage metrics.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.