feat: Support Node v18 #1041
Merged
feat: Support Node v18 #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seebees
force-pushed
the
master-force-ci
branch
from
d342773 to
dfe5158
Compare
Change the test to use the `queueMicrotask`. This keeps the call stack in bounds. node v18 was having some issues with this test.
`npm audit fix --force` This fixed `digital envelope routines`. In v17 there was an openssl breaking change. webpack needed to be updated. `npm update webpack`
seebees
changed the title
josecorella
reviewed
Oct 31, 2022
Comment on lines
+15
to
+16
| - npm -v | ||
| - node -v |
There was a problem hiding this comment.
i assume these are for debugging purposes?
There was a problem hiding this comment.
Yes, I left them in since it is using n to manually update the version.
josecorella
reviewed
Oct 31, 2022
There was a problem hiding this comment.
@seebees, should this be a feat since we are adding a new supported runtime?
josecorella
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: