Skip to content

feat: Support Node v18 #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2022
Merged

feat: Support Node v18 #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9549816
test(CB): force ci to run again with no change
texastony Oct 28, 2022
dfe5158
test(CB): for CB to run browser with node 18
texastony Oct 28, 2022
1948723
chore: update test to not stack callbacks
seebees Oct 29, 2022
860709b
chore: update package-lock
seebees Oct 29, 2022
6a026d3
update latest to v18
seebees Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions codebuild/browser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ env:

phases:
install:
runtime-versions:
nodejs: latest
commands:
- n 18
- npm ci --unsafe-perm
- npm run build
build:
commands:
- npm -v
- node -v
Comment on lines +15 to +16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume these are for debugging purposes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I left them in since it is using n to manually update the version.

- npm run coverage-browser
3 changes: 1 addition & 2 deletions codebuild/nodejs_latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ env:

phases:
install:
runtime-versions:
nodejs: latest
commands:
- n 18
- node --version ; npm --version
- npm ci --unsafe-perm
- npm run build
Expand Down
5 changes: 3 additions & 2 deletions codebuild/test_vectors/browser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,17 @@ env:

phases:
install:
runtime-versions:
nodejs: latest
commands:
- n 18
- npm ci
- |-
if [ "$PUBLISH_LOCAL" = "true" ]; then
npm run build
fi
build:
commands:
- npm -v
- node -v
- |-
if [ "$PUBLISH_LOCAL" = "true" ]; then
npm run verdaccio-publish
Expand Down
3 changes: 1 addition & 2 deletions codebuild/test_vectors/nodejs_latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ env:

phases:
install:
runtime-versions:
nodejs: latest
commands:
- n 18
- npm ci
- |-
if [ "$PUBLISH_LOCAL" = "true" ]; then
Expand Down
4 changes: 2 additions & 2 deletions modules/decrypt-node/test/decrypt.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,8 @@ function chunkCipherTextStream(ciphertext: Buffer, { size }: { size: number }) {
next: (err: Error | null, chunk: Uint8Array | null) => void
) => {
const { value, done } = eat(i, size)
if (done) return next(null, null)
next(null, new Uint8Array(value))
if (done) return queueMicrotask(() => next(null, null))
queueMicrotask(() => next(null, new Uint8Array(value)))
}
)

Expand Down
Loading