Skip to content

add function to strip nonascii and stringify numbers #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

markkuhn
Copy link
Contributor

@markkuhn markkuhn commented Aug 10, 2022

Issue #, if available: #58

Related:

Description of changes:
Added a function to strip non-ascii characters and convert numerical values to strings for dimension set values.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@markkuhn markkuhn requested review from gordonpn and removed request for Himtanaya August 12, 2022 00:39
@markkuhn markkuhn removed the request for review from caowei-amazon August 15, 2022 17:01
@markkuhn markkuhn merged commit 47bf736 into awslabs:master Aug 15, 2022
markkuhn pushed a commit that referenced this pull request Aug 18, 2022
@markkuhn markkuhn self-assigned this Sep 22, 2022
@markkuhn markkuhn added the enhancement New feature or request label Mar 2, 2023
@hussam789
Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Impact
General
Fix typo in function name

There's a typo in the test function name: "dimenions" should be "dimensions".
Fix the spelling to maintain consistency with other test function names.

tests/serializer/test_log_serializer.py [60]

-def test_serialize_dimenions_with_non_ascii_values():
+def test_serialize_dimensions_with_non_ascii_values():
  • Apply this suggestion
Suggestion importance[1-10]: 5

__

Why: Correcting the spelling mistake in the test function improves clarity and consistency in the codebase, though it is a relatively minor change.

Low
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants