Add validation for dimension, metric, namespace and timestamp #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 7, 2022
added 9 commits
September 14, 2022 12:47
update readme migrate for junit5 for some test classes fix code smells
…ed-metrics-java into dimension-validation
update link to timestamp specs
gordonpn
reviewed
Sep 16, 2022
src/main/java/software/amazon/cloudwatchlogs/emf/Constants.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/cloudwatchlogs/emf/logger/MetricsLoggerTest.java
Show resolved
Hide resolved
Co-authored-by: Gordon Pham-Nguyen <[email protected]>
Co-authored-by: Gordon Pham-Nguyen <[email protected]>
…ed-metrics-java into dimension-validation
gordonpn
approved these changes
Sep 16, 2022
giancarlokc
approved these changes
Sep 16, 2022
src/main/java/software/amazon/cloudwatchlogs/emf/environment/AgentBasedEnvironment.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Description of changes:
Added validation for dimension, metric, namespace and timestamp
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.