Fix: canary not running #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2022 15:11
gordonpn
approved these changes
Sep 1, 2022
gordonpn
reviewed
Sep 1, 2022
|
Canary successfully running here. |
gordonpn
reviewed
Sep 2, 2022
gordonpn
approved these changes
Sep 2, 2022
evanuk
approved these changes
Sep 8, 2022
Himtanaya
approved these changes
Sep 12, 2022
|
Update: Root cause was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Canary hasn't been running since fba1075.
The execution waits for
environmentFuture.join()indefinitely in the MetricsLogger flusher.This is similar to #95 but I cannot yet confirm this PR will resolve it.
The change I have made is to replace all
org.javatuples.Pairin the environments package withjava.util.Mapsince callingnew Pair<>()gets the whole thread parked indefinitely. It might be a bug in javatuples or we might not be using it properly, this I am unsure of.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.