-
Notifications
You must be signed in to change notification settings - Fork 37
Added example to use EMF Firelens for ECS Fargate #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
examples/ecs-firelens/container-definitions-fargate.template.json
Outdated
Show resolved
Hide resolved
[ | ||
{ | ||
"name": "example", | ||
"image": "<account-id>.dkr.ecr.<region>.amazonaws.com/<image-name>:latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add
"portMappings": [{ "containerPort": 8000, "protocol": "tcp" }],
Since the App is a simple server which listen on 8000..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without adding this also, when I open 0.0.0.0:8000 in the browser window, it prints the defined message on the screen which indicates that it is working without adding this config too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh how can that happen? 0.0.0.0:8000 is your local host isn't it? while this fargate instance must run on certain ip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you are correct. That can happen only when the app is running on localhost as well. That was because once I ran docker on local via Intellij and it kept running for days. But all this was without specifying any port mappings.
Issue #, if available:
Description of changes:
Added code changes required to use EMF libraries on ECS Fargate using Firelens.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.