Skip to content

Added example to use EMF Firelens for ECS Fargate #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2022

Conversation

simran029
Copy link
Contributor

@simran029 simran029 commented Jun 8, 2022

Issue #, if available:

Description of changes:
Added code changes required to use EMF libraries on ECS Fargate using Firelens.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@simran029 simran029 changed the title Added Fargate usage with Firelens example Added example to use EMF Firelens for ECS Fargate Jun 8, 2022
[
{
"name": "example",
"image": "<account-id>.dkr.ecr.<region>.amazonaws.com/<image-name>:latest",
Copy link
Contributor

@paggynie paggynie Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add

"portMappings": [{ "containerPort": 8000, "protocol": "tcp" }],

Since the App is a simple server which listen on 8000..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without adding this also, when I open 0.0.0.0:8000 in the browser window, it prints the defined message on the screen which indicates that it is working without adding this config too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh how can that happen? 0.0.0.0:8000 is your local host isn't it? while this fargate instance must run on certain ip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are correct. That can happen only when the app is running on localhost as well. That was because once I ran docker on local via Intellij and it kept running for days. But all this was without specifying any port mappings.

@simran029 simran029 requested a review from paggynie June 20, 2022 06:51
@simran029 simran029 merged commit bbd2097 into awslabs:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants