Skip to content

Fix: prevent duplicate dimensions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Conversation

markkuhn
Copy link
Contributor

Issue #, if available: #31

Description of changes:
Any duplicate dimension set in putDimensions() will replace the existing dimension set such that the newer/latest dimension value is used.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@markkuhn markkuhn added the bug Something isn't working label Aug 15, 2022
@markkuhn markkuhn changed the title Fix #31 Fix: prevent duplicate dimensions Aug 15, 2022
Copy link

@Stephen-Bao Stephen-Bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@markkuhn markkuhn merged commit 709654b into awslabs:main Aug 17, 2022
markkuhn added a commit that referenced this pull request Aug 17, 2022
@markkuhn markkuhn mentioned this pull request Aug 17, 2022
markkuhn added a commit that referenced this pull request Aug 17, 2022
@markkuhn markkuhn self-assigned this Sep 15, 2022
@markkuhn markkuhn linked an issue Sep 15, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow duplicate dimension sets
3 participants