Programatically retrieve NuGet API Key #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate from IMDSv1 to IMDSv2
* Support 30 dimensions per dimension set * Bump version to 1.0.0 Co-authored-by: Himtanaya Bhadada <[email protected]>
Upgrade .Net SDK to latest 3.1.x (CVE 2022-30184)
gordonpn
requested review from
evanuk,
giancarlokc and
Himtanaya
and removed request for
evanuk,
giancarlokc and
Himtanaya
added 3 commits
August 9, 2022 14:33
Himtanaya
reviewed
Aug 10, 2022
Himtanaya
approved these changes
Aug 10, 2022
…EMF (awslabs#26) Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Kuhn <[email protected]>
markkuhn
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Use the secrets manager instead of parameter store to pull the API key for publishing.
Reasoning: the key gets rotated, and it is a dev pain to update our parameter store manually every so often.
How this was tested
First, the
utils.shscript location needed to be fixed inscripts/publish-package.sh line 11-12.Previously, we could see it was not able to source the script
https://us-west-2.console.aws.amazon.com/codesuite/codebuild/863722843142/projects/dotnet-release/build/dotnet-release%3A4fd7a514-dddb-4a9d-8291-44d8dcdb5310/?region=us-west-2
Line 82-84
Finally,
scripts/publish-package.shscript was modified to assume the cross-account role we were given. We use the newly assumed role to retrieve the shared secret.https://us-west-2.console.aws.amazon.com/codesuite/codebuild/863722843142/projects/aws-embedded-metrics-dotnet/build/aws-embedded-metrics-dotnet%3A575f2e19-bbe5-4ea8-87d5-66bbd5507301?region=us-west-2
Line 146-147
We can see that there were no errors in pulling the secrets from secrets manager and that the validation test passed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.