Update s3 java example #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st notably the AWS SDK for Java 2.x. - Refactored the Handler and test code to work with version 2.x of the SDK. - Updated both build.gradle and pom.xml files to use latest dependencies. - Minor edit to 5-invoke.sh script which was complaining about Invalid base64. - Tested the tutorial (scripts 1 through 6) end to end and it still works.
…ity and abstraction. - Pulled out code from main handler into separate private functions. - Tested the scripts E2E to make sure they're still working. - Added additional comments in function code to explain steps. - Updated README with more explanations on what the function is doing, instead of just listing steps.
mwunderl
reviewed
Sep 8, 2022
- Revert changes to 5-invoke.sh script after noting config change - Update function timeout from 10s -> 30s in CFN stack templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This is part of an ongoing effort to improve the code samples across the Lambda developer guide.
Description of changes:
This pull request updates the s3-java sample to use the latest dependencies, most notably the AWS SDK v2. This change updates all dependencies in build.gradle and pom.xml along with the relevant code. It also generally refactors the code, and adds additional comments in both the code and README to explain more of what the function is doing.
To test these changes, I ran through all 6 of the scripts again from start to finish. All steps succeed, and upon manually checking the resulting scaled down image, the code still does what it's expected to do.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.