update: Update buildspec for TF 1.15.0 #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimidu
changed the title
saimidu
force-pushed
the
change_build_context
branch
from
ec3ded4 to
b7bd984
Compare
nadiaya
reviewed
Jan 9, 2020
| @@ -14,11 +14,10 @@ | |||
|
|
|||
| import unittest | |||
|
|
|||
| from docker.build_artifacts import deep_learning_container as deep_learning_container_to_test | |||
There was a problem hiding this comment.
nit: this import should go after pytest and request because it's our library
There was a problem hiding this comment.
Had to do this to comply with flake8 requirements.
I think module names need to be sorted in lexicographical order.
There was a problem hiding this comment.
I actually think the reason this is happening is b/c flake8 recognizes "docker" as the docker python sdk, so it thinks this is a 3rd party lib instead of a local one. One possible workaround is to noqa this line for that particular flake8 rule.
nadiaya
approved these changes
Jan 9, 2020
ddavydenko
added a commit
to ddavydenko/sagemaker-tensorflow-container
that referenced
this pull request
Jan 10, 2020
update: Update buildspec for TF 1.15.0 (aws#265)
ddavydenko
added a commit
to ddavydenko/sagemaker-tensorflow-container
that referenced
this pull request
Jan 10, 2020
ddavydenko
added a commit
to ddavydenko/sagemaker-tensorflow-container
that referenced
this pull request
Jan 10, 2020
Revert "update: Update buildspec for TF 1.15.0 (aws#265)"
ddavydenko
added a commit
to ddavydenko/sagemaker-tensorflow-container
that referenced
this pull request
Jan 10, 2020
ddavydenko
added a commit
to ddavydenko/sagemaker-tensorflow-container
that referenced
this pull request
Jan 10, 2020
Revert "Revert "update: Update buildspec for TF 1.15.0 (aws#265)""
chuyang-deng
pushed a commit
that referenced
this pull request
Feb 10, 2020
* update: Release TF 1.15.0 dockerfiles (#264) * Add TF 1.15 dockerfiles and changes to entrypoint Co-authored-by: akhilmehra <[email protected]> Co-authored-by: ElizaZh <[email protected]> Co-authored-by: Owen Thomas <[email protected]> Co-authored-by: Kartik Kalamadi <[email protected]> Co-authored-by: Arjuna Keshavan <[email protected]> Co-authored-by: akhilmehra <[email protected]> Co-authored-by: ElizaZh <[email protected]> Co-authored-by: Owen Thomas <[email protected]> Co-authored-by: Kartik Kalamadi <[email protected]> Co-authored-by: Arjuna Keshavan <[email protected]> * change: update copyright year in license header (#266) * update: Update buildspec for TF 1.15.0 (#265) * Change path for entrypoint script * Change path for deep learning container script * Change build context to folder containing dockerfiles * Update buildspec * Update buildspec-release * update: Update awscli version and remove related pins (#267) * Update awscli, remove dependent pins * Update setup.py package versions to latest * bump smdebug version to 0.5.0.post0 (#268) * bump smdebug to 0.5.0 * changed awscli to prevent botocore conflict * documentation: Add link to TF 2.0 branch (#269) * Add link to TF 2.0 branch * Add url for dockerfiles * Pin awscli to latest (#270) * pin awscli to latest version (#272) awscli==1.17.7 * infra: properly fail build if has-matching-changes fails (#273) * infra: properly fail build if has-matching-changes fails (#274) Co-authored-by: Sai Parthasarathy Miduthuri <[email protected]> Co-authored-by: akhilmehra <[email protected]> Co-authored-by: ElizaZh <[email protected]> Co-authored-by: Owen Thomas <[email protected]> Co-authored-by: Kartik Kalamadi <[email protected]> Co-authored-by: Arjuna Keshavan <[email protected]> Co-authored-by: Lauren Yu <[email protected]> Co-authored-by: Denis Davydenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Build the latest TF version in buildspec, and use folder containing dockerfile as build context
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.