Skip to content

Add EI Dockerfile for 1.11 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2019
Merged

Add EI Dockerfile for 1.11 #163

merged 5 commits into from
Feb 12, 2019

Conversation

ChoiByungWook
Copy link
Contributor

@ChoiByungWook ChoiByungWook commented Feb 10, 2019

Add Dockerfile for EI 1.11. It is based on the 1.10 CPU Dockerfile.

Added a functional end to end test based on https://github.com/awslabs/amazon-sagemaker-examples/tree/master/sagemaker-python-sdk/tensorflow_using_elastic_inference_with_your_own_model

Also updated the readme

Test results:

=== non-supported region ===
pytest -rs test/functional/test_elastic_inference.py --accelerator-type ml.eia1.medium --region ap-southeast-1

test/functional/test_elastic_inference.py::test_elastic_inference SKIPPED
============================================================================== short test summary info ==============================================================================
SKIP [1] /Users/choidan/workspace/container/sagemaker-tensorflow-containers/test/functional/test_elastic_inference.py:45: EI is not supported in ap-southeast-1

=== no accelerator provided ===
pytest -rs test/functional/test_elastic_inference.py

test/functional/test_elastic_inference.py::test_elastic_inference SKIPPED
============================================================================== short test summary info ==============================================================================
SKIP [1] /Users/choidan/workspace/container/sagemaker-tensorflow-containers/test/functional/test_elastic_inference.py:39: Skipping because accelerator type was not provided

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just one small comment.

@ChoiByungWook ChoiByungWook merged commit 79d7a57 into aws:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants