Skip to content
This repository was archived by the owner on May 23, 2024. It is now read-only.

Use js_import instead of js_include #217

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Use js_import instead of js_include #217

merged 5 commits into from
Feb 8, 2022

Conversation

satishpasumarthi
Copy link
Contributor

@satishpasumarthi satishpasumarthi commented Feb 4, 2022 •
edited
Loading

Issue #, if available:
The njs function js_include has been obsolete starting njs v0.7.1
http://nginx.org/en/docs/http/ngx_http_js_module.html#js_include

Upgraded the code to use js_import in place of js_include which requires few changes to the nginx.conf.template and the naming of .js file. (described below)

Description of changes:

  • Updated nginx.conf.template to use js_import instead of js_include
  • Renamed tensorflow-serving.js to tensorflowServing.js
  • Updated nginx.conf.template to use export definitions for the functions
  • Fixed pylint errors by passing utf-8 encoding while opening a file
  • Fixed jshint errors by adding esversion: 6 to .jshlintrc file. The export statement is available only from es6
  • Pull Ubuntu16.04 docker image from ECR rather than ubuntu to avoid docker pull limit failures

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: ac6b43a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: e35158a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: f55e934
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: f55e934
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 4637a3a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 07a6bc9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: f55e934
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: d831c91
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 997d020
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 81254bf
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: cee22d6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: ff86d85
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 6bd1269
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 6bd1269
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 6bd1269
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 6bd1269
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 34f5cf4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 34f5cf4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@satishpasumarthi satishpasumarthi changed the title js_include -> js_import and other changes Use js_import instead of js_include Feb 8, 2022
@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: f0b050c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@satishpasumarthi
Copy link
Contributor Author

@tejaschumbalkar @josephevans Could you please review the PR changes?

josephevans
josephevans approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@satishpasumarthi satishpasumarthi merged commit 3b853bd into aws:master Feb 8, 2022
@satishpasumarthi satishpasumarthi deleted the njs_upgrade branch February 8, 2022 20:05
@satishpasumarthi satishpasumarthi mentioned this pull request Feb 8, 2022
Open
@tejaschumbalkar tejaschumbalkar mentioned this pull request Feb 9, 2022
Merged
18 tasks
aws-vrnatham added a commit to aws-vrnatham/neo-ai-dlr that referenced this pull request Mar 4, 2022
@aws-vrnatham
port fix in sagemaker_serving_tensorflow_container
c04136c 
Port the
[following](aws/sagemaker-tensorflow-serving-container#217)
fix

Signed-off-by: Venky Natham <[email protected]>
apivovarov pushed a commit to neo-ai/neo-ai-dlr that referenced this pull request Mar 25, 2022
@aws-vrnatham
Add multiple versions of neuron infer dockerfiles for the frameworks (#…
8e32bf9 
…414)

* Add multiple versions of inf container

Signed-off-by: Venky Natham <[email protected]>

* change to use 2.5.2

Signed-off-by: Venky Natham <[email protected]>

* Use multi-model-server

Signed-off-by: Venky Natham <[email protected]>

* change to js_import

Signed-off-by: Venky Natham <[email protected]>

* fix syntax in nginx template

Signed-off-by: Venky Natham <[email protected]>

* add tensorflowServing.js file from the DLC repo

Signed-off-by: Venky Natham <[email protected]>

* port fix in sagemaker_serving_tensorflow_container

Port the
[following](aws/sagemaker-tensorflow-serving-container#217)
fix

Signed-off-by: Venky Natham <[email protected]>

* pin frameworks versions to sdk1.17.2 release

Signed-off-by: Venky Natham <[email protected]>

* fix mxnet18

Signed-off-by: Venky Natham <[email protected]>

* Remove ununsed file

Signed-off-by: Venky Natham <[email protected]>

* Update pillow version to latest

Signed-off-by: Venky Natham <[email protected]>

* Change pillow version

Signed-off-by: Venky Natham <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephevans josephevans josephevans approved these changes

@tejaschumbalkar tejaschumbalkar tejaschumbalkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@satishpasumarthi @sagemaker-bot @josephevans @tejaschumbalkar