Skip to content
This repository was archived by the owner on May 23, 2024. It is now read-only.

fix: modify the way port number passing #210

Merged
merged 8 commits into from
Jun 15, 2021
Merged

fix: modify the way port number passing #210

merged 8 commits into from
Jun 15, 2021

Conversation

jinpengqi
Copy link
Contributor

@jinpengqi jinpengqi commented Jun 9, 2021 •
edited
Loading

Issue #, if available:

  • some var naming issues

Description of changes:

  • Refactor naming of variables
  • Modify the way port number passing between serve.py and python service

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 1d28892
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: bd41141
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mitroviv
mitroviv reviewed Jun 10, 2021
View reviewed changes
@jinpengqi jinpengqi changed the title fix: refactor naming of some variables fix: modify to pick ports in linear fashion Jun 10, 2021
@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: e2f0d18
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mitroviv
mitroviv reviewed Jun 10, 2021
View reviewed changes
@jinpengqi jinpengqi changed the title fix: modify to pick ports in linear fashion fix: modify the way port number passing Jun 11, 2021
@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: f783aef
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mitroviv
mitroviv reviewed Jun 11, 2021
View reviewed changes
Copy link

@mitroviv mitroviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a general remark I think we should have kept using plural ports instead of switching to singular in names of the env variables and field names.

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: bb54ee3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jinpengqi
Copy link
Contributor Author

All checks failures are attributed to the same error: toomanyrequests: You have reached your pull rate limit.
This is not code side issue which testing account does not have enough ubuntu base image pulling capacity. We may wait and rerun the tests after.

mitroviv
mitroviv approved these changes Jun 11, 2021
View reviewed changes
Copy link

@mitroviv mitroviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 8199a01
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: ba83486
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-serving-container-pr
  • Commit ID: 9455619
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jinpengqi jinpengqi merged commit 6a51a60 into aws:master Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laosunhust laosunhust laosunhust approved these changes

@mitroviv mitroviv mitroviv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jinpengqi @sagemaker-bot @laosunhust @mitroviv