This repository was archived by the owner on May 23, 2024. It is now read-only.
feature: add model_version_policy to model config #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Did you tested this change with the pre/post-processing to make sure the python service will parse the inference with versions correctly? |
|
good callout - I added tests for pre-/post-processing and MME. I also deleted some duplicated code - let me know if I was missing something when I thought I could do that 😅 |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
chuyang-deng
approved these changes
Jul 28, 2020
laurenyu
added a commit
to laurenyu/deep-learning-containers
that referenced
this pull request
Jul 28, 2020
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#121
Description of changes:
This change adds the model version policy to the generated model config.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.