Numpy Installation Issue & ARM Dockerfile PyArrow Update #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabunday
reviewed
Feb 10, 2023
| # https://github.com/googleapis/google-cloud-python/issues/6647 | ||
| RUN rm -rf /miniconda3/lib/python3.7/site-packages/numpy-1.19.4.dist-info && \ | ||
| pip install --no-cache /sagemaker_sklearn_container-2.0-py3-none-any.whl && \ | ||
| RUN rm /miniconda3/lib/python3.8/site-packages/**/REQUESTED && \ |
There was a problem hiding this comment.
Should we use -f here in case the file doesn't exist going forward?
There was a problem hiding this comment.
I think it is fine if we leave it as is. These files are part of the PyPA specs, and reasons for why these files may no longer exist would relate to us not using conda or not having a requirements file. Even if in that unlikely scenario, I think it is fine for this to fail at build time on our side to force us to remove this.
mabunday
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
There is likely some package manager issue resulting in an incomplete uninstallation of numpy when it is downgraded by pip, which eventually results in installation issues with user-specified requirements. This problem exists whether we explicitly install numpy through conda or not. Note that numpy is installed by conda anyways through pyarrow even if not explicitly specified. For the time being, I am removing the specific files that are causing a problem with this process. I moved numpy back to the requirements document as it was just faster to test through the final Dockerfile as opposed the base Dockerfile since the base takes longer to build.
On a related note, merging in the following PR submitted about two weeks ago: #160.
Unit and integration tests have been ran against the new changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.