Adding multi arch buildspec for Codebuild setup #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilRaverkar
force-pushed
the
aarch64_test
branch
3 times, most recently
from
baa7052 to
18bf14e
Compare
mabunday
reviewed
Sep 9, 2022
ci/buildspec_arm.yml
Outdated
Comment on lines
36
to
37
| - docker run --rm -t test-sklearn sh -c 'pytest --cov=sagemaker_sklearn_container --cov-fail-under=60 test/unit' | ||
| - docker run --rm -t test-sklearn sh -c 'flake8 setup.py src test' |
There was a problem hiding this comment.
This is minor and I know this is carryover from the other buildspecs, but we aren't actually running tox here.
Suggested change
| - docker run --rm -t test-sklearn sh -c 'pytest --cov=sagemaker_sklearn_container --cov-fail-under=60 test/unit' | |
| - docker run --rm -t test-sklearn sh -c 'flake8 setup.py src test' | |
| - docker run --rm -t test-sklearn sh -c 'tox -e ALL' |
There was a problem hiding this comment.
test/resources/module/user_code.tar.gz is used by the integ-tests
amzn-choeric
reviewed
Oct 3, 2022
ci/buildspec_arm.yml
Outdated
| commands: | ||
| - echo Build completed on `date` | ||
| - echo Pushing the Docker image... | ||
| - docker push 515193369038.dkr.ecr.us-west-2.amazonaws.com/sagemaker-scikit-learn:$FRAMEWORK_VERSION-arm-cpu-py3 |
There was a problem hiding this comment.
Please change this to "arm64" to be consistent with XGBoost or the other way around. What it actually is (arm, arm64, etc.) does not really matter to me, but I think consistency across images would be good.
There was a problem hiding this comment.
made it consistent with XGBoost (arm64)
NikhilRaverkar
force-pushed
the
aarch64_test
branch
from
18bf14e to
19dfdcb
Compare
amzn-choeric
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
To support graviton codebuild, we need graviton specific build specs.
Description of changes: