Skip to content

Master pyarrow and integration tests fix #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2022
Merged

Master pyarrow and integration tests fix #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba32cfc
upgrading pyarrow to fix the numpy 1.21.0 broken changes
May 2, 2022
6db044e
upgrading pyarrow to fix the numpy 1.21.0 broken changes and fixing i…
May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/0.23-1/base/Dockerfile.cpu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ARG MINICONDA_VERSION=4.8.3
ARG CONDA_PY_VERSION=37
ARG CONDA_PKG_VERSION=4.9.0
ARG PYTHON_VERSION=3.7.10
ARG PYARROW_VERSION=0.16.0
ARG PYARROW_VERSION=3.0.0
ARG MLIO_VERSION=0.6.0

# Install python and other scikit-learn runtime dependencies
Expand Down
11 changes: 8 additions & 3 deletions test/integration/test_multiple_model_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,24 @@ def modulevolume():

@pytest.fixture(scope='module', autouse=True)
def container(request, docker_base_name, tag):
module_dir = os.path.join(resource_path, 'module')
model_dir = os.path.join(resource_path, 'models')

test_name = 'sagemaker-sklearn-serving-test'
try:
command = (
'docker run --name {} -p 8080:8080'
' --mount type=volume,source=dynamic_endpoint_model_volume,target=/opt/ml/model,readonly'
' --mount type=volume,source=dynamic_endpoint_module_volume,target=/user_module,readonly'
# ' --mount type=volume,source=dynamic_endpoint_model_volume,target=/opt/ml/model,readonly'
# ' --mount type=volume,source=dynamic_endpoint_module_volume,target=/user_module,readonly'
' -v {}:/opt/ml/model'
' -v {}:/user_module'
' -e SAGEMAKER_BIND_TO_PORT=8080'
' -e SAGEMAKER_SAFE_PORT_RANGE=9000-9999'
' -e SAGEMAKER_MULTI_MODEL=true'
' -e SAGEMAKER_PROGRAM={}'
' -e SAGEMAKER_SUBMIT_DIRECTORY={}'
' {}:{} serve'
).format(test_name, 'script.py', "/user_module/user_code.tar.gz", docker_base_name, tag)
).format(test_name, model_dir, module_dir, 'script.py', "/user_module/user_code.tar.gz", docker_base_name, tag)

proc = subprocess.Popen(command.split(), stdout=sys.stdout, stderr=subprocess.STDOUT)

Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ deps =
-r{toxinidir}/requirements.txt
-r{toxinidir}/test-requirements.txt
conda_deps=
pyarrow=0.16.0
pyarrow=3.0.0
mlio-py=0.5
conda_channels=
conda-forge
Expand Down