Skip to content

Merge 1.0-1 to master #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 4, 2022
Merged

Merge 1.0-1 to master #110

merged 17 commits into from
May 4, 2022

Conversation

secastillo
Copy link
Contributor

Description of changes:
Upgrading SKLearn to 1.0-1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@awsbmillare
Copy link
Contributor

I see conflicts, can those be resolved or is this intended?

@secastillo secastillo requested review from dewan-c and removed request for awsbmillare May 3, 2022 20:38
@dewan-c
Copy link
Contributor

dewan-c commented May 3, 2022

I'm still not very familiar with sklearn(good thing you also have Nikhil as reviewer :) ) . I don't see a codebuild run automatically linked here. Can you please confirm that there was a successful codebuild run for this PR, or you've run the unit/integ tests locally? Thanks!

Copy link
Contributor

@NikhilRaverkar NikhilRaverkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@secastillo secastillo merged commit e506d34 into master May 4, 2022
@mabunday mabunday deleted the 1.0-1 branch August 4, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants