Skip to content

Fix dependency versions #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 16, 2023
Merged

Fix dependency versions #162

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a07cd36
Fix dependency versions
Dec 14, 2023
c266e78
Update test dependencies
Dec 15, 2023
5bb872a
Retrigger tests
Dec 15, 2023
1c66a80
Retrigger tests
Dec 15, 2023
f5b96d9
Pin test dependency versions
Dec 15, 2023
bc44f13
Pin test dependency versions
Dec 15, 2023
8385a44
Pin tox.ini dependencies
Dec 15, 2023
371b1ed
Pause CPU integration tests
Dec 15, 2023
43cee01
Enable CPU test
Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ def read(fname):

# We don't declare our dependency on torch here because we build with
# different packages for different variants
install_requires=['boto3==1.28.60', 'numpy==1.24.4', 'six==1.16.0',
'retrying==1.3.4', 'scipy==1.10.1', 'psutil==5.9.5'],
install_requires=['boto3>=1.28.60', 'numpy>=1.24.4', 'six>=1.16.0',
'retrying>=1.3.4', 'scipy>=1.10.1', 'psutil>=5.9.5'],
extras_require={
'test': ['coverage==7.3.2', 'docker-compose==1.29.2', 'flake8==6.1.0', 'Flask==3.0.0',
'mock==5.1.0', 'pytest==7.4.2', 'pytest-cov==4.1.0', 'pytest-xdist==3.3.1',
'PyYAML==5.4.1', 'sagemaker==2.125.0', 'requests==2.31.0',
'requests_mock==1.11.0', 'torch==2.1.0', 'torchvision==0.16.0', 'tox==4.11.3']
'test': ['coverage>=7.3.2', 'docker-compose==1.29.2', 'flake8>=6.1.0', 'Flask==1.1.1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should pin on test dependency if they are not build into released artifact.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update PR.

'mock>=5.1.0', 'pytest>=7.4.2', 'pytest-cov>=4.1.0', 'pytest-xdist>=3.3.1',
'PyYAML==5.4.1', 'sagemaker==2.125.0', 'requests>=2.31.0',
'requests_mock>=1.11.0', 'torch>=2.1.0', 'torchvision>=0.16.0', 'tox>=4.11.3']
},

entry_points={
Expand Down
26 changes: 18 additions & 8 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,21 +52,31 @@ commands =
{env:IGNORE_COVERAGE:} coverage report --fail-under=90

deps =
boto3
coverage
urllib3>=1.25.4,<1.27
Flask==1.1.1
fabric
flake8==3.7.7
gitpython
invoke
mock
numpy
Pillow
packaging
pytest
pytest-cov
pytest-rerunfailures
pytest-xdist
mock
requests
urllib3
sagemaker == 2.125.0
requests_mock
retrying==1.3.3
sagemaker>=2,<3
six
tenacity
toml
torch
torchvision
retrying
six
future
PyYaml
protobuf

[testenv:flake8]
basepython = python3.8
Expand Down