Skip to content

change: Integration Tests now dynamically checks AZs #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2019
Merged

change: Integration Tests now dynamically checks AZs #989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
558660c
change: Integration Tests now dynamically checks AZs
knakad Aug 20, 2019
412b1fd
change: no longer assuming 2 subnets in 2 different AZs are required
knakad Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/integ/vpc_test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,16 @@ def _create_vpc_with_name(ec2_client, region, name):
vpc_id = ec2_client.create_vpc(CidrBlock="10.0.0.0/16")["Vpc"]["VpcId"]
print("created vpc: {}".format(vpc_id))

# sagemaker endpoints require subnets in at least 2 different AZs for vpc mode
availability_zone_name = ec2_client.describe_availability_zones()["AvailabilityZones"][0][
"ZoneName"
]

subnet_id_a = ec2_client.create_subnet(
CidrBlock="10.0.0.0/24", VpcId=vpc_id, AvailabilityZone=(region + "a")
CidrBlock="10.0.0.0/24", VpcId=vpc_id, AvailabilityZone=availability_zone_name
)["Subnet"]["SubnetId"]
print("created subnet: {}".format(subnet_id_a))
subnet_id_b = ec2_client.create_subnet(
CidrBlock="10.0.1.0/24", VpcId=vpc_id, AvailabilityZone=(region + "b")
CidrBlock="10.0.1.0/24", VpcId=vpc_id, AvailabilityZone=availability_zone_name
)["Subnet"]["SubnetId"]
print("created subnet: {}".format(subnet_id_b))

Expand Down