Skip to content

change: enable consider-merging-isinstance Pylint check #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2019
Merged

change: enable consider-merging-isinstance Pylint check #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a6d79e
change: enable consider-merging-isinstance Pylint check
knakad Jul 15, 2019
bb86181
Merge branch 'master' into 20190715-lint-merge-isinstance
knakad Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,11 @@ disable=
useless-object-inheritance, # TODO: Remove unnecessary imports
cyclic-import, # TODO: Resolve cyclic imports
no-self-use, # TODO: Convert methods to functions where appropriate
consider-merging-isinstance, # TODO: Merge isinstance where appropriate
consider-using-in, # TODO: Consider merging comparisons with "in"
too-many-public-methods, # TODO: Resolve
ungrouped-imports, # TODO: Group imports
consider-using-ternary, # TODO: Consider ternary expressions
chained-comparison, # TODO: Simplify chained comparison between operands
simplifiable-if-statement, # TODO: Simplify ifs
too-many-branches, # TODO: Simplify or ignore as appropriate
missing-docstring, # TODO: Fix missing docstring

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/tuner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def fit(self, inputs=None, job_name=None, include_cls_metadata=False, **kwargs):
**kwargs: Other arguments needed for training. Please refer to the ``fit()`` method of the associated
estimator to see what other arguments are needed.
"""
if isinstance(inputs, list) or isinstance(inputs, RecordSet):
if isinstance(inputs, (list, RecordSet)):
self.estimator._prepare_for_training(inputs, **kwargs)
else:
self.estimator._prepare_for_training(job_name)
Expand Down