Improving endpoint deletion #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesterhazy
reviewed
Dec 6, 2017
tests/integ/test_cifar.py
Outdated
| @@ -0,0 +1,45 @@ | |||
| # Copyright 2017 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
rename file to test_tf_cifar.py
laurenyu
previously approved these changes
Dec 6, 2017
tests/integ/timeout.py
Outdated
| yield [t] | ||
| finally: | ||
| sagemaker_session.delete_endpoint(endpoint_name) | ||
| LOGGER.info('deleted endpoint') |
There was a problem hiding this comment.
Adding the endpoint name to the logging statement could be helpful
laurenyu
approved these changes
Dec 6, 2017
laurenyu
pushed a commit
to laurenyu/sagemaker-python-sdk
that referenced
this pull request
May 31, 2018
Add job base class
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
athewsey
pushed a commit
to athewsey/sagemaker-python-sdk
that referenced
this pull request
May 21, 2021
FrameworkProcessor: revert `run(entry_point=...)` back to `run(code=...)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeout_and_delete_endpoint_by_namecontext manager to easily delete an endpoint in the end of the integ test