Skip to content

fix: Add ap-northeast-1 to Neo algorithms region map #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 8, 2019
Merged

fix: Add ap-northeast-1 to Neo algorithms region map #897

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
972d843
fix: Add ap-northeast-1 to Neo algorithms region map
Jul 1, 2019
4283369
Merge branch 'master' into neo-nrt
mvsusp Jul 3, 2019
433f39d
Merge branch 'master' into neo-nrt
mvsusp Jul 3, 2019
d1dfbb2
Merge branch 'master' into neo-nrt
mvsusp Jul 3, 2019
1a92af5
Merge branch 'master' into neo-nrt
chuyang-deng Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Bug fixes and other changes

* fix git test in test_estimator.py
* Add ap-northeast-1 to Neo algorithms region map

## v1.31.1 (2019-07-01)

Expand Down
8 changes: 2 additions & 6 deletions src/sagemaker/amazon/amazon_estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from sagemaker.amazon.hyperparameter import Hyperparameter as hp # noqa
from sagemaker.amazon.common import write_numpy_to_dense_tensor
from sagemaker.estimator import EstimatorBase, _TrainingJob
from sagemaker.model import NEO_IMAGE_ACCOUNT
from sagemaker.session import s3_input
from sagemaker.utils import sagemaker_timestamp, get_ecr_image_uri_prefix

Expand Down Expand Up @@ -395,12 +396,7 @@ def registry(region_name, algorithm=None):
"us-iso-east-1": "490574956308",
}[region_name]
elif algorithm in ["image-classification-neo", "xgboost-neo"]:
account_id = {
"us-west-2": "301217895009",
"us-east-1": "785573368785",
"eu-west-1": "802834080501",
"us-east-2": "007439368137",
}[region_name]
account_id = NEO_IMAGE_ACCOUNT[region_name]
else:
raise ValueError(
"Algorithm class:{} does not have mapping to account_id with images".format(algorithm)
Expand Down