Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change: allow only one integration test run per time #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: allow only one integration test run per time #880
Changes from 2 commits
131ec2a
1c3c673
bde21ff
cb94061
bc2fa85
9c7367d
6b54703
7f94164
5da7012
b420893
5273782
266d7be
0e79d18
e4d6505
6c7af65
1a5fd2a
ef94d66
21ee422
d5b46aa
29bdd84
6f3e7d4
3877f2d
eec3f3a
7916612
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per a locking system that was implemented in the Shopbop order system. You'll also want to ignore a file that is more than x hours old. To ensure dead processes don't lock forever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The process won't lock forever because the code build has a time limit as well. Let's include this as a future improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern is that a CodeBuild process dies or times out and leaves a file in S3.
In that situation, manual intervention is required to allow any future builds to run.