fix: use correct TF version in empty framework_version warning

[laurenyu]

Description of changes:
Addresses #754 (LATEST_VERSION wasn't being used in the TensorFlow estimator)

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

• I have read the CONTRIBUTING doc
• I used the commit message format described in CONTRIBUTING
• I have added tests that prove my fix is effective or that my feature works (if appropriate)
• I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[icywang86rui]

ship!

[jesterhazy]

AWS CodeBuild CI Report

• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[Nishanksingla]

self.LATEST_VERSION looks wrong to me as LATEST_VERSION is not class variable, it is defined outside the init.
It should be just LATEST_VERSION

[laurenyu]

it's defined in the class TensorFlow:

sagemaker-python-sdk/src/sagemaker/tensorflow/estimator.py

Lines 170 to 174 in 42c7f30

	class TensorFlow(Framework):
	"""Handle end-to-end training and deployment of user-provided TensorFlow code."""
	__framework_name__ = 'tensorflow'
	LATEST_VERSION = '1.12'

LATEST_VERSION (without self) would work only if it is defined outside of the TensorFlow class:

>>> class A:
...     FOO = 1
...     def __init__(self):
...         print(FOO)
... 
>>> A()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 4, in __init__
NameError: name 'FOO' is not defined

[Nishanksingla]

Ok Thanks for the explanation.

[Nishanksingla]

Still you haven't changed TF_VERSION to LATEST_VERSION

[Nishanksingla]

The initial reported issue is that TF_VERSION is set '1.11' and LATEST_VERSION is set '1.12'. TF_VERSION should be replaced by LATEST_VERSION. Or TF_VERSION should be updated to 1.12

[laurenyu]

I understand that the transition from having an updating default value to requiring framework_version be explicitly defined could be better, and I apologize for the inconvenience. There's more explanation in #754 around this, and there'll be a separate PR for the documentation changes proposed in #754.

[jesterhazy]

AWS CodeBuild CI Report

• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[jesterhazy]

AWS CodeBuild CI Report

• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[jesterhazy]

AWS CodeBuild CI Report

• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[jesterhazy]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[laurenyu]

will make a separate PR to address the doc concerns raised in #754